- Saudi Arabia
- https://4rs.nl
-
Awiteb, a university student and lover of the world of free and open source software. Programmer and enthusiast of the Rust programming language
- Joined on
1970-01-01 -
-
I hate big PR, but there is no way to make it smaller. All thing are related and need each other.
and we can even use the same structure to make it clear which is websocket and which is http
I like this, agreed
So it would be like this?
[ratelimit] enable = true connection_limit = 1500 connection_period_secs = 60
No, it will be:
[ratelimit]
enable = true
#…Another thing I thought about, would it be interesting idea to also add limit to number of connections? I know ws is light and we can handle many, but just to fend against half open connections…
why would you want to use a new file specifically for rate limiting?
Not new file, new configuration, like you say connection_ratelimit under ratelimit section.
So the new configuratio…
is this from forgejo to be compatible with github actions?
Yes it is, and imagine that there is no way to use env.FORGEJO_RUN_NUMBER for example, if you don't want to be compliant with…
@Amjad50, what do you think is better, using limit and period_secs from the ratelimit section in the config file, or creating a new configuration for the websocket rate limit?