- Malaysia
- https://amjad.alsharafi.dev
- Joined on
2024-05-31 -
-
in the client, you mentioned to make it alphabetical, should it be the same here?
ture -> true (use find and replace all, there are multiple of these)
I noticed that several methods have logcall but others don't, is it remaining from debugging session? or planning to keep it
since we are not dealing with the result. maybe a one statement approach to do
Maybe would be better to move this to WsError easier to manage errors
I hate big PR, but there is no way to make it smaller. All thing are related and need each other.
haha, yah understandable.
I'll review it soon
ah, sorry got confused. then, I think we can put them separate, and we can even use the same structure, something like this
[ratelimit.http]
limit = 1500
period_secs = 60
[ratelimit.w…So the new configurations will be
connection_limitunderratelimitsectionconnection_period_secsunderratelimitsection
The current configuration is
[ra…Another thing I thought about, would it be interesting idea to also add limit to number of connections? I know ws is light and we can handle many, but just to fend against half open connections…
it seems fine to use the same config file, since its the server config. why would you want to use a new file specifically for rate limiting?
Also, if this is per connection, maybe its better to…
the PR template seems that its for bug fixes only, I would modify it to make it general, this is an example of what I use
I notice a lot of environment variables with GITHUB is this from forgejo to be compatible with github actions? or is it here by mistake?