- Malaysia
- https://amjad.alsharafi.dev
- Joined on
2024-05-31 -
-
PublicKey and Signature as parameters
but my idea was also removing all of these calls and instead just using it in the arguments.
Middlewares cannot return a response; they can only modify it. As you can see, the response…
PublicKey and Signature as parameters
This is good, but my idea was also removing all of these calls and instead just using it in the arguments.
#[handler]
pub async fn signature_check(
req: &mut Request,
res:…PublicKey and Signature as parameters
you can fix the link to the salvo issue in the PR description ...regarding this matter [here][issue1].
Beside that, this is okay. though I notice that in signature_check middleware, we…
String to PublicKey
replace map by and_then and you won't need `and_then(
String to PublicKey
same as above, and_then instead of map
String to PublicKey
Wouldn't it be better to use Bytes type? easier to convert as its just copying bytes and making sure its the length expected and maybe more efficient
String to PublicKey
Why is it here CorePublicKey? while in oxidetails crate is just PublicKey, I think it might be confusing as we would think its 2 types.
small nitpick (also applies to have_chat_request_to below)
I would name it get_chat_request_to, as have seems that it would be boolean
yah, if you want to add it, I think we can do in this PR, just change the whitelist table (or if we are merging both, it will be a special column for blacklist)
So we can either remove it or…
We can add EndpointArgRegister implementation and thus we can use it in the arg directly