OxideTalis/oxidetalis
OxideTalis/oxidetalis
1
Fork 1
Code Issues 10 Pull requests Projects 1 Releases Activity Actions

fix: Handle the websocet in handle_socket itself #34

Manually merged
awiteb merged 1 commit from awiteb/fix-multi-spawn into master 2024-07-28 07:44:01 +02:00 AGit
Conversation 0 Commits 1 Files changed 1 +24 -29
awiteb commented 2024-07-27 11:32:05 +02:00
Owner
Copy link

I have removed the task spwaning in handle_socket function, because Salvo
already spawn handle_socket function in a new task when upgrading the
connection to websocket. So, there is no need to spawn a new task in
handle_socket function.

refs:

I have removed the task spwaning in `handle_socket` function, because Salvo already spawn `handle_socket` function in a new task when upgrading the connection to websocket. So, there is no need to spawn a new task in `handle_socket` function. refs: - Salvo task spawning: https://github.com/salvo-rs/salvo/blob/main/crates/extra/src/websocket.rs#L247-L256
awiteb added 1 commit 2024-07-27 11:32:05 +02:00
fix: Handle the websocet in handle_socket itself
All checks were successful
DCO checker / DCO checker (pull_request) Successful in 4s
Details
Rust CI / Rust CI (pull_request) Successful in 4m16s
Details
cc59b02b2d 
Signed-off-by: Awiteb <a@4rs.nl>
awiteb requested review from Amjad50 2024-07-27 11:32:27 +02:00
Amjad50 approved these changes 2024-07-27 12:00:02 +02:00
awiteb added the
Status
Approved
Kind/Bug Fix
 labels 2024-07-27 12:28:48 +02:00
awiteb manually merged commit e61de9a8b1 into master 2024-07-28 07:44:01 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Amjad50
Labels
Clear labels
  
Good First Issue

Good for newcomers

  
Help wanted

Request for help from the contributors

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Bug Fix

Pull request that fix a bug

  
Kind/CI-CD

Something related to the CI/CD

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Question

Question related to the project

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Reviewed
Accepted
Feature Request or Proposal was accepted by maintainers and will be implemented

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Declined
Feature Request or Proposal was declined by maintainers

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Approved
The PR is approved by reviewers and is ready to be merged

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Inactive
Inactive and waiting on the author. This is often applied to closed PRs

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Status
Waiting On Author
This is awaiting some action (such as code changes or more information) from the author

  
Status
Waiting On Review
Awaiting review from the assignee

No labels
Good First Issue
Help wanted
Kind/Breaking
Kind/Bug
Kind/Bug Fix
Kind/CI-CD
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Question
Kind/Security
Kind/Testing
Reviewed
Accepted
Reviewed
Confirmed
Reviewed
Declined
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Approved
Status
Blocked
Status
Inactive
Status
Need More Info
Status
Waiting On Author
Status
Waiting On Review
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: OxideTalis/oxidetalis#34
No description provided.
Delete branch "awiteb/fix-multi-spawn"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?